Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cdp): site apps handle consent #1555

Closed
wants to merge 7 commits into from
Closed

feat(cdp): site apps handle consent #1555

wants to merge 7 commits into from

Conversation

MarconLP
Copy link
Member

@MarconLP MarconLP commented Nov 26, 2024 •
edited
Loading

Changes

  • Adds a disable_site_apps_destinations property that will disable all site_destination's
  • Checks if the property is enabled every time set_config is being called.
  • Updated the nextjs example to disable/enable site_destination's based on the cookie banner (link)

TODOs:

  • add tests

Checklist

  • Tests for new code (see advice on the tests we use)
  • Accounted for the impact of any changes across different browsers
  • Accounted for backwards compatibility of any changes (no breaking changes in posthog-js!)

@vercel Vercel
Copy link

vercel bot commented Nov 26, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview Nov 27, 2024 9:25am

@github-actions GitHub Actions
Copy link

Size Change: +1.36 kB (+0.04%)

Total Size: 3.16 MB

Filename Size Change
dist/array.full.es5.js 257 kB +137 B (+0.05%)
dist/array.full.js 360 kB +137 B (+0.04%)
dist/array.full.no-external.js 359 kB +137 B (+0.04%)
dist/array.js 174 kB +136 B (+0.08%)
dist/array.no-external.js 173 kB +136 B (+0.08%)
dist/main.js 175 kB +136 B (+0.08%)
dist/module.full.js 360 kB +137 B (+0.04%)
dist/module.full.no-external.js 359 kB +137 B (+0.04%)
dist/module.js 174 kB +136 B (+0.08%)
dist/module.no-external.js 173 kB +136 B (+0.08%)
ℹ️ View Unchanged
Filename Size
dist/all-external-dependencies.js 206 kB
dist/dead-clicks-autocapture.js 14.3 kB
dist/exception-autocapture.js 9.36 kB
dist/external-scripts-loader.js 2.29 kB
dist/recorder-v2.js 115 kB
dist/recorder.js 115 kB
dist/surveys-preview.js 57.6 kB
dist/surveys.js 63.2 kB
dist/tracing-headers.js 1.75 kB
dist/web-vitals.js 10.3 kB

compressed-size-action

@MarconLP MarconLP changed the base branch from client-side-hog to main November 27, 2024 09:57
@MarconLP MarconLP changed the base branch from main to client-side-hog November 27, 2024 09:58
Base automatically changed from client-side-hog to main November 27, 2024 10:27
@MarconLP
Copy link
Member Author

close in favor of #1563

@MarconLP MarconLP closed this Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarconLP @mariusandra